HADOOP-19490. S3A: AWS SDK 2.30+ incompatible with third party stores#7494
Closed
steveloughran wants to merge 6 commits intoapache:trunkfrom
Closed
HADOOP-19490. S3A: AWS SDK 2.30+ incompatible with third party stores#7494steveloughran wants to merge 6 commits intoapache:trunkfrom
steveloughran wants to merge 6 commits intoapache:trunkfrom
Conversation
Upgrade to 2.30.27 Change-Id: Ic0652dc95c619559c45c9f0a153813b73a076d13
AwsSdkWorkarounds no longer needs to cut back on transfer manager logging (HADOOP-19272). Remove log downgrade and change assertion to expect nothing to be logged. Change-Id: I5edcf674c1eede8327538979ddab2fe98d2e53e2
Change in state of AwsExecutionAttribute.ENDPOINT_OVERRIDDEN attribute requires test tuning to match. Change-Id: I80050ce9ffffa6b4f1b05dd16e83b18d2ce63678
Refresh IAM credentials a hard coded 60s before the session credentials fully expire. Change-Id: I2a61584cc99d761cc4b9af6a669224f309425088
Switch is in client; commented out in test log properties; covered in troubleshooting doc Change-Id: If70447d8eb3d3d0e03db5c169cd1aabf844931bd
Adds aws recommended workaround. doesn't fix it. Change-Id: I137b414599410493fe5a83a8bee3b848d08bd24f
steveloughran
changed the title
Contributor
|
Hi Steve, this is unrelated but I noticed that the v2 s3 client has a close() method, and looking at the tutorial doc it seems to expect users to close it at the end. Looking at Hadoop S3A code I found a few test code where it is not closed. That may require your attention. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@jojochuang Thanks for looking for this...just reviewed the code We close them in |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How was this patch tested?
Dell ECS S3 store. tests fail.
This PR is just up as a "here is where I gave up" PR
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?